bpo-26243: data= is positional-only just on CPython by ambv · Pull Request #11754 · python/cpython
Conversation
PyPy can take it as keyword just fine.
I think it would be more correct to remove too strong failing assertions. Other tests should be passed on PyPy.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I test it on ubuntu 18.04 and its good.
| x = zlib.compress(HAMLET_SCENE) | ||
| self.assertEqual(zlib.decompress(x), HAMLET_SCENE) | ||
|
|
||
| @support.cpython_only |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only the TypeError check that should be skipped, right? Not the whole test.
| self.assertIsInstance(dco.unconsumed_tail, bytes) | ||
| self.assertIsInstance(dco.unused_data, bytes) | ||
|
|
||
| @support.cpython_only |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
ambv
deleted the
cpython_only_zlib
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters