gh-112075: Lock when inserting into shared keys by colesbury · Pull Request #117824 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@colesbury

Copy link Copy Markdown

Contributor

@colesbury colesbury commented

Apr 12, 2024

edited by bedevere-app bot

Loading

This is a draft PR similar to #117528, but:

  1. Separates out the handling of split keys
  2. Doesn't yet handle the necessary locking in _Py_dict_lookup for things like the PyDict_GetItemRef locking fallback.

@colesbury colesbury closed this

Apr 26, 2024

@colesbury

Copy link Copy Markdown

Contributor Author

Addressed in #117528

@colesbury colesbury deleted the gh-112075-lock-split-keys branch

July 16, 2024 19:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane methane will be requested when the pull request is marked ready for review methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@colesbury