gh-112075: use per-thread dict version pool by DinoV · Pull Request #118676 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
gh-112075: use per-thread dict version pool#118676
DinoV merged 2 commits intopython:mainfrom
gh-112075: use per-thread dict version pool#118676
DinoV merged 2 commits intopython:mainfrom
Conversation
Copy link Copy Markdown
Contributor
We want to avoid contention on the dict version. This moves to using a per-thread pool of 256 dict versions that we can allocate from without hitting the atomic operation for the main thread.
DinoV
requested a review
from ericsnowcurrently
as a code owner
bedevere-app
bot
added
the
awaiting core review
label
bedevere-app
bot
mentioned this pull request
DinoV
added
skip news
topic-free-threading
labels
DinoV
requested a review
from colesbury
colesbury reviewed May 6, 2024
Include/internal/pycore_dict.h
Outdated
Show resolved
Hide resolved
Include/internal/pycore_dict.h Outdated Show resolved Hide resolved
colesbury approved these changes May 6, 2024
bedevere-app
bot
added
awaiting merge
and removed
awaiting core review
labels
DinoV added 2 commits
May 6, 2024 16:43
DinoV
force-pushed
the
nogil_dict_version
branch
from
4d6906a to
adb5e13
Compare
DinoV
enabled auto-merge (squash)
DinoV
merged commit
ff6cbb2
into
python:main
bedevere-app
bot
removed
the
awaiting merge
label
SonicField pushed a commit to SonicField/cpython that referenced this pull request
May 8, 2024use thread state set of dict versions
DinoV
deleted the
nogil_dict_version
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment