bpo-35928: textio, set decoded_chars to NULL with check · Pull Request #11878

bpo-35928: textio, set decoded_chars to NULL with check · Pull Request #11878 · python/cpython

Closed

ghost wants to merge 7 commits intomasterfrom

unknown repository

Conversation

decoded_chars should be set to NULL when there is a
snapshot prior to clearing the snapshot in TextIOWrapper
write and read. This is ZackerySpytz change with an
addition.

https://bugs.python.org/issue35928

		@@ -0,0 +1 @@
		TextIOWrapper now correctly handles the decoding buffer in read-write mode, using sockets aswell. No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What "using sockets as well" means?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Issue 35928 the initial symptom was about sockets using socket.makefile truncating the output to a client, as seen in the first test case.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the note to sockets as this is a side effect.

ghost closed this

Feb 20, 2019

ghost deleted the fix-bpo-35928 branch

February 20, 2019 00:30

pravn mannequin mentioned this pull request

Jan 5, 2024

This pull request was closed.

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Labels