bpo-36073: Raise ProgrammingError on recursive usage of cursors in sqlite converters by sir-sigurd · Pull Request #11984 · python/cpython

@sir-sigurd

auvipy

auvipy

BoboTiG

@BoboTiG

Thanks @sir-sigurd, I think a NEWs entry would be interesting, don't you?

@erlend-aasland

erlend-aasland

Comment on lines 365 to 366

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format these lines according to PEP 7.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than 79 characters, ref. PEP 7.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased onto master in order to fit in with the changes in the test suite.

@sir-sigurd

@erlend-aasland
I'll try to rebase in the near future, though I almost do not remember anything about this.

@erlend-aasland

I'll try to rebase in the near future, though I almost do not remember anything about this.

Thanks, there's no hurry :)

@sir-sigurd

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erlend-aasland

@erlend-aasland

Could you rebase again (bco. GH-27884), @sir-sigurd? :)

Also, please clean up the regression test:

  • line length is limited to 79 chars
  • please use double quotes

@sir-sigurd

heitbaum added a commit to heitbaum/LibreELEC.tv that referenced this pull request

May 17, 2022

@heitbaum