[3.7] bpo-21478 - Autospec functions should propagate mock calls to parent GH-11273 by miss-islington · Pull Request #12039 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.5k
Merged
cjw296 merged 1 commit intopython:3.7from
Mar 3, 2019Merged
Conversation
Copy link Copy Markdown
Contributor
(cherry picked from commit 9c3f284)
Co-authored-by: Xtreak tir.karthi@gmail.com
(cherry picked from commit 9c3f284) Co-authored-by: Xtreak <tir.karthi@gmail.com>
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
eamanu approved these changes Feb 26, 2019
bedevere-bot
added
awaiting core review
and removed
awaiting review
labels
Copy link Copy Markdown
Member
tirkarthi
commented
Mar 3, 2019
tirkarthi commented
Mar 3, 2019Not sure how bpo number got removed in the backport. It will be good if this can be added to the title so that this can be linked in the tracker.
cc: @cjw296
Copy link Copy Markdown
Contributor
cjw296
commented
Mar 3, 2019
cjw296 commented
Mar 3, 2019I likely screwed something up. Feels like the bots are no longer quite managing to link these backport PRs back to the original one. I'll try fiddling...
cjw296
changed the title
[3.7] Autospec functions should propagate mock calls to parent GH-11273
[3.7] bpo-21478 - Autospec functions should propagate mock calls to parent GH-11273
cjw296
merged commit
4b9459d
into
python:3.7
Copy link Copy Markdown
bedevere-bot
commented
Mar 3, 2019
bedevere-bot commented
Mar 3, 2019@cjw296: Please replace # with GH- in the commit message next time. Thanks!
bedevere-bot
removed
the
awaiting core review
label
miss-islington
deleted the
backport-9c3f284-3.7
branch
Copy link Copy Markdown
Member
tirkarthi
commented
Mar 3, 2019
tirkarthi commented
Mar 3, 2019I guess it was missing in the original commit though PR had it and the bot made a backport without number in the title. Thanks for merging this :) I will close the bug in the tracker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants