[2.7] bpo-36147: Fix a variable going out of scope. by stratakis · Pull Request #12102 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@stratakis

Copy link Copy Markdown

Contributor

@stratakis stratakis commented

Feb 28, 2019

edited by bedevere-bot

Loading

The s_get function leaks the result variable.
Partially backport commit 19b5254
to fix it.

https://bugs.python.org/issue36147

The s_get function leaks the result variable.
Partially backport commit 19b5254
to fix it.
Copy link Copy Markdown

Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's a copy of the code used in the master branch.

@vstinner vstinner merged commit 098b139 into python:2.7

Mar 6, 2019

@stratakis stratakis deleted the bpo36147 branch

June 18, 2020 13:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stratakis @vstinner @the-knights-who-say-ni @bedevere-bot