Duplicate test function in test_site by native-api · Pull Request #12140 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
methane merged 1 commit intopython:masterfrom
Mar 3, 2019Merged
Duplicate test function in test_site#12140
methane merged 1 commit intopython:masterfrom
Duplicate test function in test_site#12140
methane merged 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
native-api
commented
Mar 2, 2019
native-api
commented
Pycharm caught this as "overriden method without use".
the-knights-who-say-ni
added
the
CLA signed
label
native-api
changed the title
Removed duplicate test function
Remove duplicate test function in test_site
Mariatta reviewed Mar 2, 2019
Lib/test/test_site.py Outdated
native-api
force-pushed
the
test_site_duplicate
branch
from
6db0fa0 to
15962e3
Compare
Copy link Copy Markdown
Member
tirkarthi
commented
Mar 3, 2019
tirkarthi commented
Mar 3, 2019methane reviewed Mar 3, 2019
native-api
changed the title
Remove duplicate test function in test_site
Duplicate test function in test_site
Copy link Copy Markdown
Contributor Author
native-api
commented
Mar 3, 2019
native-api commented
Mar 3, 2019@methane et al
As per #12140 (comment) , it turns out, the first test_getuserbase tests _getuserbase while the second one tests getuserbase.
So it doesn't make sense to merge them.
methane approved these changes Mar 3, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
eamanu approved these changes Mar 3, 2019
methane
added
skip issue
skip news
labels
methane
merged commit
45d8d24
into
python:master
bedevere-bot
removed
the
awaiting merge
label
Copy link Copy Markdown
Member
I guess this change can be backported since test is present in 3.7 too.
methane
added
the
needs backport to 3.7
label
Copy link Copy Markdown
Contributor
miss-islington
commented
Mar 3, 2019
miss-islington commented
Mar 3, 2019Thanks @native-api for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Mar 3, 2019(cherry picked from commit 45d8d24) Co-authored-by: native-api <ivan_pozdeev@mail.ru>
Copy link Copy Markdown
bedevere-bot
commented
Mar 3, 2019
bedevere-bot commented
Mar 3, 2019GH-12152 is a backport of this pull request to the 3.7 branch.
bedevere-bot
removed
the
needs backport to 3.7
label
miss-islington added a commit that referenced this pull request
Mar 3, 2019(cherry picked from commit 45d8d24) Co-authored-by: native-api <ivan_pozdeev@mail.ru>
native-api
deleted the
test_site_duplicate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment