bpo-30121: Fix debug assert in subprocess on Windows by segevfiner · Pull Request #1224 · python/cpython

vstinner

This is caused by closing HANDLEs using os.close which is for CRT file
descriptors and not for HANDLEs.

@segevfiner

vstinner added a commit that referenced this pull request

Aug 21, 2017
…3173)

* bpo-30121: Fix debug assert in subprocess on Windows (#1224)

* bpo-30121: Fix debug assert in subprocess on Windows

This is caused by closing HANDLEs using os.close which is for CRT file
descriptors and not for HANDLEs.

* bpo-30121: Suppress debug assertion in test_subprocess when ran directly

(cherry picked from commit 4d38517)

* Add test_subprocess.test_nonexisting_with_pipes() (#3133)

bpo-30121: Test the Popen failure when Popen was created with pipes.
Create also NONEXISTING_CMD variable in test_subprocess.py.
(cherry picked from commit 9a83f65)

@segevfiner segevfiner deleted the issue-30121-windows-subprocess-debug-assert branch

August 22, 2017 18:31