[WIP] bpo-36263: Fix hashlib.scrypt() by vstinner · Pull Request #12280 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
[WIP] bpo-36263: Fix hashlib.scrypt()#12280
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:test_scrypt
[WIP] bpo-36263: Fix hashlib.scrypt()#12280
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:test_scrypt
Conversation
Copy link Copy Markdown
Member
Fix hashlib.scrypt(): pass the salt when validating arguments.
Fix hashlib.scrypt(): pass the salt when validating arguments.
vstinner
added
the
needs backport to 3.7
label
vstinner
requested a review
from tiran
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting merge
label
Copy link Copy Markdown
Member Author
vstinner
commented
Mar 11, 2019
vstinner commented
Mar 11, 2019cc @stratakis
vstinner
added
the
DO-NOT-MERGE
label
vstinner
changed the title
bpo-36263: Fix hashlib.scrypt()
[WIP] bpo-36263: Fix hashlib.scrypt()
Copy link Copy Markdown
Member Author
vstinner
commented
Mar 11, 2019
vstinner commented
Mar 11, 2019test_hashlib only fails on Fedora which has a downstream patch: https://bugs.python.org/issue36263#msg337685
I contacted the Fedora openssl package maintainer to see if he can fix the downstream patch instead.
vstinner
mentioned this pull request
2 tasks
Copy link Copy Markdown
Member Author
vstinner
commented
Apr 16, 2019
vstinner commented
Apr 16, 2019OpenSSL regression has been fixed in Fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=1688284
I close the PR.
vstinner
closed this
vstinner
deleted the
test_scrypt
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment