gh-122905: Sanitize names in zipfile.Path. by jaraco · Pull Request #122906 · python/cpython

@jaraco

@jaraco jaraco commented

Aug 11, 2024

edited by bedevere-app bot

Loading

@jaraco

@jaraco

@jaraco

This behavior has been published in jaraco/zipp since 2024-05-31, so I'm confident it's stable.

@miss-islington-app

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13.
🐍🍒⛏🤖

@jaraco jaraco deleted the bugfix/122905-malformed-zipfile-path-inputs branch

August 11, 2024 23:48

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 11, 2024
Ported from zipp 3.19.1; ref jaraco/zippGH-119.
(cherry picked from commit 9cd0326)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

@bedevere-app

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 11, 2024
Ported from zipp 3.19.1; ref jaraco/zippGH-119.
(cherry picked from commit 9cd0326)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

@bedevere-app

@miss-islington-app

Sorry, @jaraco, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.11

@miss-islington-app

Sorry, @jaraco, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.10

@miss-islington-app

Sorry, @jaraco, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.9

@miss-islington-app

Sorry, @jaraco, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.8

jaraco added a commit to jaraco/cpython that referenced this pull request

Aug 12, 2024

jaraco added a commit to jaraco/cpython that referenced this pull request

Aug 12, 2024
)

Ported from zipp 3.19.1; ref jaraco/zippGH-119.
(cherry picked from commit 9cd0326)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

@bedevere-app

@jaraco

I've proposed the backport to 3.11. I'm hoping to cherrypick that to 3.10 and earlier, assuming it's accepted, rather that cherry-picking the change in main and re-reconciling the conflicts.

jaraco pushed a commit that referenced this pull request

Aug 12, 2024

jaraco pushed a commit that referenced this pull request

Aug 12, 2024

pablogsal pushed a commit that referenced this pull request

Aug 19, 2024

jaraco added a commit to jaraco/cpython that referenced this pull request

Aug 19, 2024

jaraco added a commit to jaraco/cpython that referenced this pull request

Aug 19, 2024

@bedevere-app

@bedevere-app

@bedevere-app

blhsing pushed a commit to blhsing/cpython that referenced this pull request

Aug 22, 2024

@jaraco @blhsing

@jaraco

That's weird - all three backports (3.8, 3.9, 3.10) are failing on the macos runners, two of them with segmentation faults. I'm 99.9% certain these changes aren't directly implicated. I've restarted the runners to see if maybe that clears things up, but there seems to be some stability issues on those branches.

pablogsal pushed a commit that referenced this pull request

Aug 22, 2024

@jaraco

@obfusk

This introduced a regression: #123270.

Guddu786i