Home Original page

bpo-27497: Add return value to csv.DictWriter.writeheader by remilapeyre · Pull Request #12306 · python/cpython

@remilapeyre

vstinner

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please modify your commit message to credit the author using Co-Authored-By markup?

Co-Authored-By: Ashish Nitin Patil <ashishnitinpatil@gmail.com>

@remilapeyre

Thanks, I wanted to do this but was missing his email address. I will add the documentation for writerow tomorrow.

vstinner

vadmium

Rémi Lapeyre added 2 commits

March 15, 2019 14:10

@remilapeyre

Hi @vstinner @vadmium! I made the requested changes, can you review again?

I also opened #12344 regarding the naming of the attribute writeline of WriterObj.

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would prefer that another core dev also reviews it.

@smontanaro

LGTM. I downloaded the patch, applied it and verified the tests pass. @vstinner I no longer have (nor want) commit privileges. Can you take this the last mile if you have a moment?

@vstinner

LGTM. I downloaded the patch, applied it and verified the tests pass. @vstinner I no longer have (nor want) commit privileges. Can you take this the last mile if you have a moment?

Done, thanks for the review @smontanaro ;-)