Home Original page

[WIP] bpo-36287: Ignoring optional field. by eamanu · Pull Request #12328 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@eamanu

Copy link Copy Markdown

Contributor

@eamanu eamanu commented

Mar 14, 2019

•

edited by bedevere-bot

Loading

To avoid unnecessary verbose this PR add and if to know
if the field to return is not None

https://bugs.python.org/issue36287

To avoid unnecessary verbose this PR add and `if` to know
if the field to return is not None
Comment thread

Lib/ast.py Outdated

@eamanu eamanu changed the title bpo-36287: Ignoring optional field. [WIP] bpo-36287: Ignoring optional field.

Mar 20, 2019

@brettcannon

Copy link Copy Markdown

Member

Why is this a WIP? If this truly isn't ready to be considered for review then please close the PR.

@eamanu

Copy link Copy Markdown

Contributor Author

eamanu commented

Mar 26, 2019

Hi @brettcannon. I will close it now. I am working on this Issue, but you are right, when I have the "final" PR I will open it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise requested changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eamanu @brettcannon @matrixise @the-knights-who-say-ni @bedevere-bot