[3.6] bpo-36272: Logging now propagates RecursionError (GH-12312) by miss-islington · Pull Request #12339 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
miss-islington wants to merge 1 commit intopython:3.6from
Closed
[3.6] bpo-36272: Logging now propagates RecursionError (GH-12312)#12339
miss-islington wants to merge 1 commit intopython:3.6from
[3.6] bpo-36272: Logging now propagates RecursionError (GH-12312)#12339
miss-islington wants to merge 1 commit intopython:3.6from
Conversation
Copy link Copy Markdown
Contributor
(cherry picked from commit 65f64b1)
Co-authored-by: Rémi Lapeyre remi.lapeyre@henki.fr
(cherry picked from commit 65f64b1) Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Mar 15, 2019
miss-islington commented
Mar 15, 2019@remilapeyre and @vsajip: Status check is done, and it's a success ✅ .
remilapeyre approved these changes Mar 15, 2019
bedevere-bot
added
awaiting core review
and removed
awaiting review
labels
Mariatta
requested a review
from ned-deily
Copy link Copy Markdown
Member
Mariatta
commented
Mar 17, 2019
Mariatta commented
Mar 17, 2019I don't think this counts as security fix. I'll let @ned-deily review.
Copy link Copy Markdown
Member
ned-deily
commented
Mar 18, 2019
ned-deily commented
Mar 18, 2019I agree that this does not appear to be a security fix. @vsajip, unless you disagree strongly, I'll plan to close this.
vsajip
closed this
miss-islington
deleted the
backport-65f64b1-3.6
branch
Copy link Copy Markdown
Member
vsajip
commented
Mar 18, 2019
vsajip commented
Mar 18, 2019Sorry for the noise - I wasn't paying enough attention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment