[3.9] gh-123270: Replaced SanitizedNames with a more surgical fix. (GH-123354) by jaraco · Pull Request #123432 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
[3.9] gh-123270: Replaced SanitizedNames with a more surgical fix. (GH-123354)#123432
ambv merged 2 commits intopython:3.9from
[3.9] gh-123270: Replaced SanitizedNames with a more surgical fix. (GH-123354)#123432
ambv merged 2 commits intopython:3.9from
Conversation
Copy link Copy Markdown
Member
Applies changes from zipp 3.20.1 and jaraco/zipp#124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb)
Supersedes #123161.
…gical fix. (pythonGH-123354) Applies changes from zipp 3.20.1 and jaraco/zippGH-124 (cherry picked from commit 2231286) (cherry picked from commit 17b77bb) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
This was referenced
Aug 28, 2024
bedevere-app
bot
added
the
awaiting core review
label
Copy link Copy Markdown
Member Author
jaraco
commented
Aug 28, 2024
jaraco commented
Aug 28, 2024Although the build fails, we can be confident that the functionality is good, because these changes were adopted by zipp 3.20.1 and tested against Python 3.9 on macOS.
Copy link Copy Markdown
Member Author
jaraco
commented
Sep 2, 2024
jaraco commented
Sep 2, 2024I don't understand why the tests are passing on Windows when two of the the 3.10 tests in #123426 were failing on Windows.
Copy link Copy Markdown
Member Author
jaraco
commented
Sep 2, 2024
jaraco commented
Sep 2, 2024Aha! It's because in Python 3.9, zipfile.Path.name still uses posixpath.
ambv
merged commit
9620552
into
python:3.9
bedevere-app
bot
removed
the
awaiting core review
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment