bpo-34160: Add the sort attribute to the xml.dom.minidom.Node.writexml method by matrixise · Pull Request #12354 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@matrixise

Copy link Copy Markdown

Member

@matrixise matrixise commented

Mar 15, 2019

edited by bedevere-bot

Loading

…texml and xml.dom.minidom.Node.writexml method.

Document the new sort attribute and xml.dom.minidom.Document.writexml
method.

@matrixise matrixise marked this pull request as ready for review

March 15, 2019 20:36

@matrixise matrixise closed this

Mar 15, 2019

@matrixise matrixise reopened this

Mar 15, 2019

@matrixise

Copy link Copy Markdown

Member Author

I closed/reopen the PR there was an issue with appveyor

@matrixise

Copy link Copy Markdown

Member Author

in fact, there was some issues in my code :/ not detected locally but fortunately AppVeyor was there ;-)

@tirkarthi

Copy link Copy Markdown

Member

I think this is the same as #10452 that has a discussion about adding a new sort parameter.

@matrixise

Copy link Copy Markdown

Member Author

I close this PR

@matrixise matrixise closed this

Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matrixise @tirkarthi @the-knights-who-say-ni @bedevere-bot