bpo-34160: Add the sort attribute to the xml.dom.minidom.Node.writexml method by matrixise · Pull Request #12354 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
matrixise wants to merge 3 commits intopython:masterfrom
Closed
bpo-34160: Add the sort attribute to the xml.dom.minidom.Node.writexml method#12354
matrixise wants to merge 3 commits intopython:masterfrom
bpo-34160: Add the sort attribute to the xml.dom.minidom.Node.writexml method#12354
matrixise wants to merge 3 commits intopython:masterfrom
Conversation
Copy link Copy Markdown
Member
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
matrixise
force-pushed
the
bpo-34160
branch
3 times, most recently
from
c9f321f to
b7a3e1d
Compare
…texml and xml.dom.minidom.Node.writexml method. Document the new sort attribute and xml.dom.minidom.Document.writexml method.
matrixise
force-pushed
the
bpo-34160
branch
from
b7a3e1d to
1de91f4
Compare
matrixise
marked this pull request as ready for review
matrixise
closed this
matrixise
reopened this
Copy link Copy Markdown
Member Author
matrixise
commented
Mar 15, 2019
matrixise commented
Mar 15, 2019I closed/reopen the PR there was an issue with appveyor
matrixise added 2 commits
March 15, 2019 21:56Copy link Copy Markdown
Member Author
matrixise
commented
Mar 15, 2019
matrixise commented
Mar 15, 2019in fact, there was some issues in my code :/ not detected locally but fortunately AppVeyor was there ;-)
Copy link Copy Markdown
Member
tirkarthi
commented
Mar 15, 2019
tirkarthi commented
Mar 15, 2019I think this is the same as #10452 that has a discussion about adding a new sort parameter.
Copy link Copy Markdown
Member Author
matrixise
commented
Mar 17, 2019
matrixise commented
Mar 17, 2019I close this PR
matrixise
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment