bpo-36308: Fix _PyPathConfig_ComputeArgv0 warning by matrixise · Pull Request #12357 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
matrixise wants to merge 1 commit intopython:masterfrom
Closed
bpo-36308: Fix _PyPathConfig_ComputeArgv0 warning#12357
matrixise wants to merge 1 commit intopython:masterfrom
bpo-36308: Fix _PyPathConfig_ComputeArgv0 warning#12357
matrixise wants to merge 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Member
'argv0' may be used uninitialized in this function
'argv0' may be used uninitialized in this function
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
matrixise
marked this pull request as ready for review
Copy link Copy Markdown
Member Author
matrixise
commented
Mar 19, 2019
matrixise commented
Mar 19, 2019I close the PR, #12441 fixes the issue.
matrixise
closed this
Copy link Copy Markdown
Member
vstinner
commented
Mar 19, 2019
vstinner commented
Mar 19, 2019When I read your PR, I didn't understand it, but I now think that PR #12441 is the correct: leave sys.path unchanged if sys.argv is empty.
Copy link Copy Markdown
Member Author
matrixise
commented
Mar 19, 2019
matrixise commented
Mar 19, 2019@vstinner you have a better overview than me on the code/project.
Copy link Copy Markdown
Member
vstinner
commented
Mar 19, 2019
vstinner commented
Mar 19, 2019("I didn't understand it": I mean that I didn't understand the root issue, not your PR.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment