[3.7] bpo-36307: Travis: upgrade to Xenial environment (GH-12356) by methane · Pull Request #12405 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
[3.7] bpo-36307: Travis: upgrade to Xenial environment (GH-12356)#12405
[3.7] bpo-36307: Travis: upgrade to Xenial environment (GH-12356)#12405
Conversation
Copy link Copy Markdown
Member
(cherry picked from commit 74ae50e)
Co-authored-by: CAM Gerlach CAM.Gerlach@Gerlach.CAM
(cherry picked from commit 74ae50e) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
skip issue
label
bedevere-bot
mentioned this pull request
bedevere-bot
added
skip news
awaiting merge
labels
methane added 6 commits
March 18, 2019 22:20Copy link Copy Markdown
Member
tirkarthi
commented
Mar 18, 2019
tirkarthi commented
Mar 18, 2019Not sure if it helps but this seems to be a related issue : travis-ci/travis-ci#8363 . I can see more users with the workaround - pyenv global system 3.5 (Replacing 3.5 with 3.7?) in before_install (pre-commit/pre-commit@e3ab890)
Copy link Copy Markdown
Member
tirkarthi
commented
Mar 18, 2019
tirkarthi commented
Mar 18, 2019Seems to work with the workaround (tirkarthi@95a193c)
before_install:
- pyenv global system 3.7
Ref : https://travis-ci.org/tirkarthi/cpython/jobs/507972151
Fails without workaround
Ref : https://travis-ci.org/tirkarthi/cpython/jobs/507981710
methane added 2 commits
March 19, 2019 14:53Copy link Copy Markdown
Member Author
methane
commented
Mar 19, 2019
methane commented
Mar 19, 2019pyenv is great, but I hate pyenv shims. It slows down python startup more than 5x. It adds many garbage commands in PATH. It's crazy.
methane added 2 commits
March 19, 2019 16:25
methane
merged commit
09e5877
into
3.7
bedevere-bot
removed
the
awaiting merge
label
methane
deleted the
backport-74ae50e-3.7
branch
Copy link Copy Markdown
Member
tirkarthi
commented
Mar 19, 2019
tirkarthi commented
Mar 19, 2019Agreed. I searched for any fixes but I couldn't get any other solution other than the workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment