bpo-36345: Doc: make serve uses http.server instead of Tools/scripts/server.py by matrixise · Pull Request #12408 · python/cpython

@matrixise

@matrixise

@JulienPalard here is the PR where we deprecate Tools/scripts/serve.py

@JulienPalard

@vstinner should we write a version of Python in which this file should be removed in the message? This is not really a module, I don't think we should follow PEP 4, but I'd like to remove it slowly just in case someone found the file and though "hey let's use it!"

@matrixise You have forgotten to remove serve.py from the Tools README, and to update make.bat.

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@matrixise

I have made the requested changes; please review again

@bedevere-bot

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinner

@matrixise

I have made the requested changes; please review again

@bedevere-bot

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@matrixise

@matrixise

@vstinner I have updated this PR with your remark (modify the makefile first). this is the part-0 for this issue.

The part-2 is #12511 (sorry, I don't rename the branch)
The part-1 will arrive after you have approved the part-0.

I have made the requested changes; please review again

Thank you

@bedevere-bot

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "use http.server"? You should mention "make server" somewhere.

@matrixise

Hi @vstinner thank you for your review

I have made the requested changes; please review again

@bedevere-bot

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinner

Please squash your commits into a single commit and update the PR title and description. It became very unclear what is the purpose of this change, because of its long history.

@matrixise

@matrixise matrixise changed the title bpo-36345: Deprecate Tools/scripts/serve.py in favour of the HTTP server bpo-36345: Doc: make serve uses http.server instead of Tools/scripts/server.py

May 15, 2019

@hugovk