gh-126390: Support for preserving order of options and nonoption arguments in gnu_getopt() by serhiy-storchaka · Pull Request #126393 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.1k
Comments
Merged
serhiy-storchaka merged 2 commits intopython:mainfrom
Nov 13, 2024Merged
Conversation
bedevere-app
bot
added
the
awaiting core review
label
bedevere-app
bot
mentioned this pull request
gpshead reviewed Nov 6, 2024
Lib/test/test_getopt.py
Show resolved
Hide resolved
Lib/test/test_getopt.py Show resolved Hide resolved
Copy link
Member Author
serhiy-storchaka
commented
Nov 6, 2024
serhiy-storchaka commented
Nov 6, 2024This PR should be merged after #126375 (where that typo was already fixed.).
Copy link
Contributor
erlend-aasland
commented
Nov 6, 2024
erlend-aasland commented
Nov 6, 2024This PR should be merged after #126375 (where that typo was already fixed.).
So let's mark it as a draft to make that more obvious.
serhiy-storchaka
marked this pull request as draft
bedevere-app
bot
removed
the
awaiting core review
label
serhiy-storchaka and others added 2 commits
November 11, 2024 18:32…n arguments in gnu_getopt()
serhiy-storchaka
force-pushed
the
getopt-return-in-order
branch
from
1b6a8e2 to
aff48a2
Compare
serhiy-storchaka
marked this pull request as ready for review
bedevere-app
bot
added
the
awaiting core review
label
Copy link
Member Author
serhiy-storchaka
commented
Nov 11, 2024
serhiy-storchaka commented
Nov 11, 2024Now this PR only contains the changes for #126390.
Lib/getopt.py
Show resolved
Hide resolved
Lib/getopt.py Show resolved Hide resolved
gpshead
mentioned this pull request
gpshead approved these changes Nov 13, 2024
Copy link
Member
gpshead
left a comment
gpshead
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice feature!
bedevere-app
bot
added
awaiting merge
and removed
awaiting core review
labels
Copy link
Member Author
serhiy-storchaka
commented
Nov 13, 2024
serhiy-storchaka commented
Nov 13, 2024Thank you for your review @gpshead.
serhiy-storchaka
merged commit
35010b8
into
python:main
bedevere-app
bot
removed
the
awaiting merge
label
serhiy-storchaka
deleted the
getopt-return-in-order
branch
serhiy-storchaka
mentioned this pull request
picnixz pushed a commit to picnixz/cpython that referenced this pull request
Dec 8, 2024…n arguments in gnu_getopt() (pythonGH-126393)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request
Jan 12, 2025…n arguments in gnu_getopt() (pythonGH-126393)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment