Home Original page

Typo: delete duplicated test case by MakDon · Pull Request #12662 · python/cpython

@MakDon

Delete a duplicated test case in re_tests.
In the original version, line 109 seems to be the same with 112, which means line 112 is duplicated.
According to "Trivial changes, like fixing a typo, do not need an issue.", no issue was created in the https://bugs.python.org.

@MakDon

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@nanjekyejoannah

@MakDon There is no need then to put "bpo-None:" Just write the PR title in this case.

see : #12613

@MakDon MakDon changed the title bpo-None:Typo-delete duplicated test case Typo: delete duplicated test case

Apr 3, 2019

@MakDon

tirkarthi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiy-storchaka

Comparing with other tests, it is more likely this test should contain \r instead of \n.

@MakDon 

edit line 112 .
Before:
('(?s)a.b', 'a\nb', SUCCEED, 'found', 'a\nb'),
After:
('(?s)a.b', 'a\rb', SUCCEED, 'found', 'a\rb'),

serhiy-storchaka

@MakDon

@serhiy-storchaka
It was modified from ('a.b(?s)', 'a\nb', SUCCEED, 'found', 'a\nb')
After the commit bd48d27 , flags should be used first in the expression string.
So it was edited to (?s)a.b, which was duplicated.
A new commit has made in which i replace \n with \r

The Azure Pipeline PR was failed because GitHub reported the error, "Request timed out after 100000 ms".I am not familiar with it and i dont know how to deal with it.
Thanks for your review.

@serhiy-storchaka

Thank you for your contribution @MakDon!

@tirkarthi

@tirkarthi

@serhiy-storchaka Does this file in general have duplicates as part of the same list for some reason?

('ab*', 'xayabbbz', SUCCEED, 'found', 'a'),
('ab*', 'xayabbbz', SUCCEED, 'found', 'a'),

Adding below to the file I can see some more duplicates :

test_map = {}

for test in tests:
    key = test[0] + test[1]
    if key not in test_map:
        test_map[key] = None
    else:
        print(f"duplicate {test[0]} {test[1]}")

print("Set returns ", len(set(map(lambda x: (x[0] + x[1]), tests))))
print("List returns ", len(tests))
Set returns  396
List returns  508

@MakDon

It seems that this tests are combined from several parts such as # All tests from Perl, which cause the duplicated tests.