Home Original page

[3.7] bpo-36508: python-config don't export LINKFORSHARED (GH-12661) by miss-islington · Pull Request #12748 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

Copy link Copy Markdown

Contributor

@miss-islington miss-islington commented

Apr 9, 2019

•

edited by bedevere-bot

Loading

python-config --ldflags no longer includes flags of the LINKFORSHARED
variable. The LINKFORSHARED variable must only be used to build
executables.
(cherry picked from commit e65f01f)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue36508

python-config --ldflags no longer includes flags of the LINKFORSHARED
variable. The LINKFORSHARED variable must only be used to build
executables.
(cherry picked from commit e65f01f)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner

Copy link Copy Markdown

Member

vstinner commented

Apr 9, 2019

The backport is straightfoward, but I would prefer to see the buildbot runnings on it before merging it into 3.7.

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@vstinner vstinner merged commit cd46b09 into python:3.7

Apr 16, 2019

@miss-islington miss-islington deleted the backport-e65f01f-3.7 branch

April 16, 2019 13:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot