bpo-24011: Use PyModule_AddIntMacro in PyInit__signal() by nanjekyejoannah · Pull Request #12765 · python/cpython

@nanjekyejoannah

berkerpeksag

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@berkerpeksag

Also, the title of the pull request is outdated :) We can update it with something like "Use PyModule_AddIntMacro in PyInit__signal()" since the places you've updated already have error checks in place.

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah changed the title bpo-24011: Add error checks to PyInit_signal() bpo-24011: Use PyModule_AddIntMacro in PyInit__signal()

Apr 11, 2019

@nanjekyejoannah

@berkerpeksag I have made the requested changes; please review again

@bedevere-bot

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@nanjekyejoannah

@nanjekyejoannah

@berkerpeksag

@berkerpeksag

berkerpeksag

@berkerpeksag