Home Original page

bpo-36613: call remove_done_callback if exception by gescheit · Pull Request #12800 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@gescheit

Copy link Copy Markdown

Contributor

@gescheit gescheit commented

Apr 12, 2019

•

edited by bedevere-bot

Loading

Call remove_done_callback() in finally block.

https://bugs.python.org/issue36613

@miss-islington

Copy link Copy Markdown

Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @gescheit for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link Copy Markdown

GH-13076 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 3, 2019 
Call remove_done_callback() in finally block.

https://bugs.python.org/issue36613
(cherry picked from commit c1964e9)

Co-authored-by: gescheit <gescheit12@gmail.com>

miss-islington added a commit that referenced this pull request

May 3, 2019 
Call remove_done_callback() in finally block.

https://bugs.python.org/issue36613
(cherry picked from commit c1964e9)

Co-authored-by: gescheit <gescheit12@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gescheit @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni