bpo-36645: Fix ambiguous formatting in re.sub() documentation. by mollison · Pull Request #12879 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mollison

Copy link Copy Markdown

Contributor

@mollison mollison commented

Apr 19, 2019

edited by bedevere-bot

Loading

This PR also needs to be backported to 3.7.

https://bugs.python.org/issue36645

@serhiy-storchaka

Copy link Copy Markdown

Member

Are there precedences of using versionchanged with the same version multiple times sequentially?

@mollison

Copy link Copy Markdown

Contributor Author

@serhiy-storchaka yes. Here are some examples.

versionchanged::3.7 repeated sequentially:
https://docs.python.org/3/library/collections.html#collections.namedtuple

versionchanged::3.2 repeated sequentially:
https://docs.python.org/3/library/urllib.request.html#urllib.request.urlopen

versionchanged::3.7 repeated sequentially:
https://docs.python.org/3/library/dis.html#dis.dis

If you want to look at this issue in greater depth, subprocess.Popen is a more complicated case:
https://docs.python.org/3/library/subprocess.html#subprocess.Popen

Copy link Copy Markdown

Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that multi-line version{added,changed} markers don't render well:

Screen Shot 2019-04-22 at 1 11 25 AM

This PR makes the note more readable.

LGTM, thank you!

@berkerpeksag berkerpeksag merged commit 5ebfa84 into python:master

Apr 21, 2019

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @mollison for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 21, 2019
…GH-12879)

(cherry picked from commit 5ebfa84)

Co-authored-by: mollison <mollison@cs.unc.edu>

@bedevere-bot

Copy link Copy Markdown

GH-12898 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request

Apr 21, 2019
(cherry picked from commit 5ebfa84)

Co-authored-by: mollison <mollison@cs.unc.edu>

@mollison mollison deleted the fix-issue-36645 branch

April 21, 2019 22:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mollison @serhiy-storchaka @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni