bpo-36645: Fix ambiguous formatting in re.sub() documentation. by mollison · Pull Request #12879 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
berkerpeksag merged 1 commit intopython:masterfrom
Apr 21, 2019Merged
bpo-36645: Fix ambiguous formatting in re.sub() documentation.#12879
berkerpeksag merged 1 commit intopython:masterfrom
bpo-36645: Fix ambiguous formatting in re.sub() documentation.#12879
berkerpeksag merged 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
This PR also needs to be backported to 3.7.
the-knights-who-say-ni
added
the
CLA signed
label
Copy link Copy Markdown
Member
serhiy-storchaka
commented
Apr 19, 2019
serhiy-storchaka commented
Apr 19, 2019Are there precedences of using versionchanged with the same version multiple times sequentially?
Copy link Copy Markdown
Contributor Author
mollison
commented
Apr 19, 2019
mollison commented
Apr 19, 2019@serhiy-storchaka yes. Here are some examples.
versionchanged::3.7 repeated sequentially:
https://docs.python.org/3/library/collections.html#collections.namedtuple
versionchanged::3.2 repeated sequentially:
https://docs.python.org/3/library/urllib.request.html#urllib.request.urlopen
versionchanged::3.7 repeated sequentially:
https://docs.python.org/3/library/dis.html#dis.dis
If you want to look at this issue in greater depth, subprocess.Popen is a more complicated case:
https://docs.python.org/3/library/subprocess.html#subprocess.Popen
berkerpeksag
added
skip news
needs backport to 3.7
labels
berkerpeksag approved these changes Apr 21, 2019
Copy link Copy Markdown
Member
berkerpeksag
left a comment
berkerpeksag
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
berkerpeksag
merged commit
5ebfa84
into
python:master
Copy link Copy Markdown
Contributor
miss-islington
commented
Apr 21, 2019
miss-islington commented
Apr 21, 2019Thanks @mollison for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
bedevere-bot
removed
the
awaiting merge
label
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Apr 21, 2019
bedevere-bot
removed
the
needs backport to 3.7
label
Copy link Copy Markdown
bedevere-bot
commented
Apr 21, 2019
bedevere-bot commented
Apr 21, 2019GH-12898 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request
Apr 21, 2019
mollison
deleted the
fix-issue-36645
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
