bpo-36683: rename duplicate function test_io_encoding to test_pyio_encoding by Windsooon · Pull Request #12896 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
bpo-36683: rename duplicate function test_io_encoding to test_pyio_encoding#12896
zooba merged 1 commit intopython:masterfrom
bpo-36683: rename duplicate function test_io_encoding to test_pyio_encoding#12896
zooba merged 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
rename duplicate function test_io_encoding to test_pyio_encoding
the-knights-who-say-ni
added
the
CLA signed
label
Windsooon
changed the title
bpo-36682: rename duplicate function test_io_encoding to test_pyio_encoding
bpo-36683: rename duplicate function test_io_encoding to test_pyio_encoding
eamanu approved these changes Apr 22, 2019
Copy link Copy Markdown
Contributor
eamanu
left a comment
eamanu
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. What about join both check on one test?
bedevere-bot
added
awaiting core review
and removed
awaiting review
labels
zooba
added
the
skip news
label
zooba
merged commit
f51dd4f
into
python:master
bedevere-bot
removed
the
awaiting core review
label
Copy link Copy Markdown
Member
zooba
commented
Apr 22, 2019
zooba commented
Apr 22, 2019Better to keep the tests separate so that we get more accurate reporting of which one failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment