Home Original page

gh-112075: Remove critical section in dict.get by eendebakpt · Pull Request #129336 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@eendebakpt

Copy link Copy Markdown

Contributor

@eendebakpt eendebakpt commented

Jan 27, 2025

•

edited by bedevere-app bot

Loading

  • The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic.
  • Add a test for concurrent dict get and set operations

@colesbury colesbury enabled auto-merge (squash)

January 28, 2025 21:33

@colesbury

Copy link Copy Markdown

Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eendebakpt @colesbury