bpo-2091: Fix typo in exception message by berkerpeksag · Pull Request #12987 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
berkerpeksag merged 1 commit intopython:masterfrom
Apr 27, 2019Merged
bpo-2091: Fix typo in exception message#12987
berkerpeksag merged 1 commit intopython:masterfrom
bpo-2091: Fix typo in exception message#12987
berkerpeksag merged 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Member
berkerpeksag
added
skip news
needs backport to 3.7
labels
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
tirkarthi approved these changes Apr 27, 2019
Copy link Copy Markdown
Member
tirkarthi
left a comment
tirkarthi
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am not sure of backporting this to 3.7. There was a similar typo fixed in Lib/random.py error message and was not backported to 3.7 as noted in https://bugs.python.org/issue35782#msg334364.
Thanks.
Copy link Copy Markdown
Member Author
berkerpeksag
commented
Apr 27, 2019
berkerpeksag commented
Apr 27, 2019We don't backport changes to existing error messages only when we significantly changed their formats. 2433a2a and this one are completely OK to backport.
berkerpeksag
merged commit
21a9ba1
into
python:master
Copy link Copy Markdown
Contributor
miss-islington
commented
Apr 27, 2019
miss-islington commented
Apr 27, 2019Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
bedevere-bot
removed
the
awaiting core review
label
berkerpeksag
deleted the
fix-open-error-message
branch
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Apr 27, 2019(cherry picked from commit 21a9ba1) Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
bedevere-bot
removed
the
needs backport to 3.7
label
Copy link Copy Markdown
bedevere-bot
commented
Apr 27, 2019
bedevere-bot commented
Apr 27, 2019GH-12988 is a backport of this pull request to the 3.7 branch.
berkerpeksag added a commit that referenced this pull request
Apr 27, 2019This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment