bpo-6584: Add a BadGzipFile exception to the gzip module by ZackerySpytz · Pull Request #13022

bpo-6584: Add a BadGzipFile exception to the gzip module by ZackerySpytz · Pull Request #13022 · python/cpython

Merged

serhiy-storchaka merged 2 commits intopython:masterfrom

ZackerySpytz:bpo-6584-gzip-BadGzipFile

May 13, 2019

Merged

bpo-6584: Add a BadGzipFile exception to the gzip module#13022
serhiy-storchaka merged 2 commits intopython:masterfrom
ZackerySpytz:bpo-6584-gzip-BadGzipFile

Conversation

Copy link Copy Markdown

Contributor

ZackerySpytz commented
Apr 30, 2019
•

edited by bedevere-bot

Loading

Co-Authored-By: Filip Gruszczyński gruszczy@gmail.com
Co-Authored-By: Michele Orrù maker@tumbolandia.net

https://bugs.python.org/issue6584

bpo-6584: Add a BadGzipFile exception to the gzip module

aef8e13

Co-Authored-By: Filip Gruszczyński <gruszczy@gmail.com>
Co-Authored-By: Michele Orrù <maker@tumbolandia.net>

the-knights-who-say-ni added the CLA signed label

Apr 30, 2019

bedevere-bot added the awaiting review label

Apr 30, 2019

Copy link Copy Markdown

Contributor Author

ZackerySpytz commented
Apr 30, 2019

EOFError can be raised in some cases in the gzip module, and this was added to match with
bz2 and lzma (https://bugs.python.org/issue1159051 / cc0172c). I don't think these cases should be replaced with BadGzipFile.

auvipy approved these changes May 2, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels

May 2, 2019

Copy link Copy Markdown

Member

serhiy-storchaka commented
May 2, 2019

It should be documented clearly that BadGzipFile is not the only exception raised by corrupted gzip files. EOFError and zlib.error also can be raised.