bpo-36802: Drop awrite()/aclose(), support await write() and await close() instead by asvetlov · Pull Request #13099

bpo-36802: Drop awrite()/aclose(), support await write() and await close() instead by asvetlov · Pull Request #13099 · python/cpython

The PR requires #13098
That's why I've merged that code to this branch.
I'm trying to keep PRs isolated but it is not always possible, sorry.

		return fut
		if not self._protocol._paused:
		return self._complete_fut
		return self._loop.create_task(self.drain())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to avoid creating task in majority of the cases, e.g.:

In the stream __init__:

   self._nop = self.loop.create_future()
   self._nop.set_result(None)

and then in _fast_drain:

   if not self._paused:
        return self._nop

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I do almost the same a few lines above.
There is no writer._paused attribute but writer._protocol._paused one (which has undefined state if the protocol is closing).
That's why I have slightly more comlex logic that you mentioned in a comment but the functionality is the same.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, never mind. Could you please add a comment before return self._complete_fut that it's a "fast path"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

1st1 approved these changes May 9, 2019

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!