gh-93096: Move `random` benchmark into pyperformance by donbarbos · Pull Request #131144 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a performance test. It is used by module maintainers to view generated distributions to see if they match the expected distributions.
I think it would be right to get rid of the --test flags in modules with cli.
This flag is not documented and is not displayed in the --help output.
And it seems author of this flag is not against removing it
I'm going to decline this. It isn't part of the public API so there is no user benefit to removing it. I do use this when maintaining the module so it does have some value. And the test code has nothing to do with pyperformance so this PR would be moving the code from where a mainainer can find it to a place where it clearly doesn't make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters