gh-128813: hide mixed-mode functions for complex arithmetic from C-API by skirpichev · Pull Request #131703 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.3k
Merged
vstinner merged 2 commits intopython:mainfrom
Apr 22, 2025Merged
gh-128813: hide mixed-mode functions for complex arithmetic from C-API#131703
vstinner merged 2 commits intopython:mainfrom
gh-128813: hide mixed-mode functions for complex arithmetic from C-API#131703
vstinner merged 2 commits intopython:mainfrom
Conversation
skirpichev
added
the
skip news
label
skirpichev
requested a review
from vstinner
bedevere-app
bot
added
the
awaiting review
label
bedevere-app
bot
mentioned this pull request
Copy link
Member Author
skirpichev
commented
Mar 25, 2025
skirpichev commented
Mar 25, 2025CC @vstinner
vstinner reviewed Mar 25, 2025
Modules/_testcapi/complex.c
Outdated
Show resolved
Hide resolved
Modules/_testcapi/complex.c Outdated Show resolved Hide resolved
skirpichev
requested review from
a team and
erlend-aasland
as code owners
vstinner approved these changes Mar 25, 2025
Copy link
Member
vstinner
left a comment
vstinner
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bedevere-app
bot
added
awaiting merge
and removed
awaiting review
labels
Copy link
Member Author
I doubt C-API WG issue will be solved til 3.14 beta1. So, lets remove added functions from the public API.
Copy link
Member Author
skirpichev
commented
Apr 22, 2025
skirpichev commented
Apr 22, 2025
Copy link
Member
vstinner
commented
Apr 22, 2025
vstinner commented
Apr 22, 2025Related discussion: capi-workgroup/decisions#56
Copy link
Member Author
skirpichev
commented
Apr 22, 2025
skirpichev commented
Apr 22, 2025I just worry, that it will be not finished til 3.14 beta. Or it's ok to revert this stuff after that?
vstinner
added
the
release-blocker
label
github-project-automation
bot
added this to Release and Deferred blockers 🚫
github-project-automation
bot
moved this to Todo
in Release and Deferred blockers 🚫
github-project-automation
bot
moved this from Todo
to Done
in Release and Deferred blockers 🚫
bedevere-app
bot
removed
the
awaiting merge
label
Copy link
Member
vstinner
commented
Apr 22, 2025
vstinner commented
Apr 22, 2025Ok, let's remove them for now. We can revisit this API later if we decide to expose it.
vstinner
removed
the
release-blocker
label
skirpichev
deleted the
remove-mixed-api/128813
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment