bpo-36783: Add new references for C API Documentation changes by edison12a · Pull Request #13204 · python/cpython

bpo-36783: Add new references for C API Documentation changes by edison12a · Pull Request #13204 · python/cpython

edison12a changed the title ~~Added new references for C API Documentation changes~~ bpo-36783 Added new references for C API Documentation changes

		.. versionadded:: 3.6


		.. c:function:: PyObject* PyTime_FromTime(int hour, int minute, int second, int usecond)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you move this paragraph?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved that paragraph to create a better order as requested by @pganssle so that PyTime_FromTimeAndFold follows PyTime_FromTime which is a better order for a user who will be reading the docs.

		@@ -0,0 +1 @@
		Add new references for C API Documentationadditions of Time_FromTimeAndFold and PyDateTime_FromDateAndTimeAndFold. Patch by Edison Abahurire.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this blurb. @matrixise or someone can just add the "skip news" label, but this is just a fixup from the previous PR, which was merged a bit prematurely.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pganssle
I have removed the blurb. Please review the change.
@matrixise

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Edison!

@matrixise @csabella Do one of you mind adding the "skip news" label? This is a fixup for the earlier PR, so it already has a corresponding blurb.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

matrixise changed the title ~~bpo-36783 Added new references for C API Documentation changes~~ bpo-36783: Add new references for C API Documentation changes

@matrixise This needs a backport to Python 3.7 as well.

Ping @matrixise or @csabella - is it too late to add the "needs backport" label? The original change that this is a fixup for was backported to 3.7, but this PR wasn't.

Thanks @SimiCode for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

…GH-13204)

(cherry picked from commit d28772a)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>

miss-islington added a commit that referenced this pull request

(cherry picked from commit d28772a)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>