Home Original page

bpo-36862: Add VS2019 to env.bat by tonybaloney · Pull Request #13215 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tonybaloney

Copy link Copy Markdown

Contributor

@tonybaloney tonybaloney commented

May 9, 2019

•

edited by bedevere-bot

Loading

@tonybaloney

Copy link Copy Markdown

Contributor Author

Requesting review from @zooba and @zware

Comment thread

PCbuild/env.bat

echo Build environments: x86, amd64, x86_amd64
echo.
set VSTOOLS=%VS140COMNTOOLS%
if "%VSTOOLS%"=="" set VSTOOLS=%VS160COMNTOOLS%
Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct - we'll want some detection more like what's in find_msbuild.bat (using the vswhere.exe app - and if that's not there, then neither VS 2017 or VS 2019 are installed!)

@tonybaloney

Copy link Copy Markdown

Contributor Author

So, I've discovered that the scripts don't work with prerelease versions of Visual Studio. You can use the -prerelease flag for vswhere so that would discover MSBuild, but as VS2019 is now released, this seems like an edge-case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tonybaloney @zooba @auvipy @the-knights-who-say-ni @bedevere-bot