bpo-33303: ElementTree Comment text isn't escaped by websurfer5 · Pull Request #13229 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
websurfer5 wants to merge 11 commits intopython:masterfrom
Closed
bpo-33303: ElementTree Comment text isn't escaped#13229
websurfer5 wants to merge 11 commits intopython:masterfrom
bpo-33303: ElementTree Comment text isn't escaped#13229
websurfer5 wants to merge 11 commits intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
properly escape XML comment text, plus test
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
scoder reviewed May 10, 2019
Misc/NEWS.d/next/Library/2019-05-09-22-36-41.bpo-33303.B7_POx.rst Outdated
websurfer5 added 3 commits
May 10, 2019 21:57
Copy link Copy Markdown
Contributor
scoder
commented
May 11, 2019
scoder commented
May 11, 2019Also, since this is a backwards incompatible change, this also needs to be mentioned in the "What's new" document: https://github.com/python/cpython/blob/master/Doc/whatsnew/3.8.rst#xml
websurfer5 and others added 6 commits
May 11, 2019 22:07added in commit 6e36d47.
Copy link Copy Markdown
Contributor
scoder
commented
May 12, 2019
scoder commented
May 12, 2019Thank you for your work and a perfect PR. I'm really sorry that I have to reject this feature.
scoder
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment