Home Original page

[3.7] bpo-36807: When saving a file in IDLE, call flush and fsync (GH-13102) by miss-islington · Pull Request #13280 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

Copy link Copy Markdown

Contributor

@miss-islington miss-islington commented

May 13, 2019

•

edited by bedevere-bot

Loading

(cherry picked from commit 4f098b3)

Co-authored-by: Guido van Rossum guido@python.org

https://bugs.python.org/issue36807

…-13102)

(cherry picked from commit 4f098b3)

Co-authored-by: Guido van Rossum <guido@python.org>

@miss-islington

Copy link Copy Markdown

Contributor Author

@gvanrossum and @terryjreedy: Status check is done, and it's a failure ❌ .

1 similar comment

@miss-islington

Copy link Copy Markdown

Contributor Author

@gvanrossum and @terryjreedy: Status check is done, and it's a failure ❌ .

@gvanrossum

Copy link Copy Markdown

Member

I suppose this needs to be merged manually? IIRC the Azure Pipelines test build is still flaky.

@@ -0,0 +1 @@
When saving a file, call os.flush() so bits are flushed to e.g. USB drive.
Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo, I think, should say call os.fsync().

Fix typo in NEWS item about IDLE (os.flush() should be os.fsync())

@miss-islington miss-islington deleted the backport-4f098b3-3.7 branch

May 13, 2019 16:06

@terryjreedy

Copy link Copy Markdown

Member

Cannot merge when required test fails, even if irrelevant to patch. I forgot that that cannot close and reopen backport to rerun tests for backport. Will redo backport and correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@terryjreedy terryjreedy terryjreedy approved these changes

+1 more reviewer

@dhalbert dhalbert dhalbert requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting merge type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @gvanrossum @terryjreedy @dhalbert @the-knights-who-say-ni @bedevere-bot