[2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) by tirkarthi · Pull Request #13426 · python/cpython
Expand Up
@@ -368,6 +368,7 @@ def test_domain_return_ok(self):
("http://foo.bar.com/", ".foo.bar.com", True),
("http://foo.bar.com/", "foo.bar.com", True),
("http://foo.bar.com/", ".bar.com", True),
("http://foo.bar.com/", "bar.com", True),
("http://foo.bar.com/", "com", True),
("http://foo.com/", "rhubarb.foo.com", False),
("http://foo.com/", ".foo.com", True),
Expand All
@@ -378,6 +379,8 @@ def test_domain_return_ok(self):
("http://foo/", "foo", True),
("http://foo/", "foo.local", True),
("http://foo/", ".local", True),
("http://barfoo.com", ".foo.com", False),
("http://barfoo.com", "foo.com", False),
]:
request = urllib2.Request(url)
r = pol.domain_return_ok(domain, request)
Expand Down
Expand Up
@@ -938,6 +941,33 @@ def test_domain_block(self):
c.add_cookie_header(req)
self.assertFalse(req.has_header("Cookie"))
c.clear()
pol.set_blocked_domains([]) req = Request("http://acme.com/") res = FakeResponse(headers, "http://acme.com/") cookies = c.make_cookies(res, req) c.extract_cookies(res, req) self.assertEqual(len(c), 1)
req = Request("http://acme.com/") c.add_cookie_header(req) self.assertTrue(req.has_header("Cookie"))
req = Request("http://badacme.com/") c.add_cookie_header(req) self.assertFalse(pol.return_ok(cookies[0], req)) self.assertFalse(req.has_header("Cookie"))
p = pol.set_blocked_domains(["acme.com"]) req = Request("http://acme.com/") c.add_cookie_header(req) self.assertFalse(req.has_header("Cookie"))
req = Request("http://badacme.com/") c.add_cookie_header(req) self.assertFalse(req.has_header("Cookie"))
def test_secure(self): from cookielib import CookieJar, DefaultCookiePolicy
Expand Down
c.clear()
pol.set_blocked_domains([]) req = Request("http://acme.com/") res = FakeResponse(headers, "http://acme.com/") cookies = c.make_cookies(res, req) c.extract_cookies(res, req) self.assertEqual(len(c), 1)
req = Request("http://acme.com/") c.add_cookie_header(req) self.assertTrue(req.has_header("Cookie"))
req = Request("http://badacme.com/") c.add_cookie_header(req) self.assertFalse(pol.return_ok(cookies[0], req)) self.assertFalse(req.has_header("Cookie"))
p = pol.set_blocked_domains(["acme.com"]) req = Request("http://acme.com/") c.add_cookie_header(req) self.assertFalse(req.has_header("Cookie"))
req = Request("http://badacme.com/") c.add_cookie_header(req) self.assertFalse(req.has_header("Cookie"))
def test_secure(self): from cookielib import CookieJar, DefaultCookiePolicy
Expand Down