bpo-36983: Fix typing.__all__ and add test for exported names by asottile · Pull Request #13456 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
miss-islington merged 1 commit intopython:masterfrom
May 29, 2019Merged
bpo-36983: Fix typing.__all__ and add test for exported names#13456
miss-islington merged 1 commit intopython:masterfrom
bpo-36983: Fix typing.__all__ and add test for exported names#13456
miss-islington merged 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Contributor
asottile
requested review from
gvanrossum and
ilevkivskyi
as code owners
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
Carreau approved these changes May 29, 2019
bedevere-bot
added
awaiting core review
and removed
awaiting review
labels
Copy link Copy Markdown
Contributor
Carreau
commented
May 29, 2019
Carreau commented
May 29, 2019(also will need a rebase/fix conflicts.)
asottile
force-pushed
the
typing_all_bpo-36983
branch
from
cb7699d to
587dc7a
Compare
gvanrossum approved these changes May 29, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
gvanrossum
added
🤖 automerge
labels
miss-islington
merged commit
d30da5d
into
python:master
Copy link Copy Markdown
Contributor
miss-islington
commented
May 29, 2019
miss-islington commented
May 29, 2019Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..
1 similar comment
Copy link Copy Markdown
Contributor
miss-islington
commented
May 29, 2019
miss-islington commented
May 29, 2019Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..
Copy link Copy Markdown
Contributor
miss-islington
commented
May 29, 2019
miss-islington commented
May 29, 2019Thanks @asottile for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
bedevere-bot
removed
the
awaiting merge
label
Copy link Copy Markdown
Contributor
miss-islington
commented
May 29, 2019
miss-islington commented
May 29, 2019I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Will retry in 1 minute. Retry # 1
asottile
deleted the
typing_all_bpo-36983
branch
Copy link Copy Markdown
bedevere-bot
commented
May 29, 2019
bedevere-bot commented
May 29, 2019GH-13662 is a backport of this pull request to the 3.7 branch.
bedevere-bot
removed
the
needs backport to 3.7
label
asottile added a commit to asottile/cpython that referenced this pull request
May 29, 2019
bedevere-bot
removed
the
needs backport to 3.6
label
Copy link Copy Markdown
bedevere-bot
commented
May 29, 2019
bedevere-bot commented
May 29, 2019GH-13663 is a backport of this pull request to the 3.6 branch.
asottile added a commit to asottile/cpython that referenced this pull request
May 29, 2019miss-islington pushed a commit that referenced this pull request
May 30, 2019DinoV pushed a commit to DinoV/cpython that referenced this pull request
Jan 14, 2020This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants