Home Original page

bpo-34616: Fix code style and unbreak buildbots by 1st1 · Pull Request #13473 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@1st1

Copy link Copy Markdown

Member

@1st1 1st1 commented

May 21, 2019

•

edited by bedevere-bot

Loading

@1st1

Copy link Copy Markdown

Member Author

1st1 commented

May 21, 2019

@ned-deily Ned, could you please approve this PR? The buildbots were breaking because the previous commit used the new f'{debug=}' feature, that's not apparently yet supported by test_unparse.py.

@ned-deily

Copy link Copy Markdown

Member

@1st1, I force pushed it for you. I assume @ambv won't mind :)

@1st1 1st1 deleted the fix34616 branch

May 21, 2019 21:23

@1st1

Copy link Copy Markdown

Member Author

1st1 commented

May 21, 2019

Thank you, Ned!

Yeah, I was thinking about the bright black future while fixing the style :)

ned-deily reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@1st1 @ned-deily @the-knights-who-say-ni @bedevere-bot