bpo-36876: Use a consistent variable name for kwlist. by ericsnowcurrently · Pull Request #13531 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.2k
Closed
ericsnowcurrently wants to merge 1 commit intopython:masterfrom
Closed
bpo-36876: Use a consistent variable name for kwlist.#13531
ericsnowcurrently wants to merge 1 commit intopython:masterfrom
bpo-36876: Use a consistent variable name for kwlist.#13531
ericsnowcurrently wants to merge 1 commit intopython:masterfrom
Conversation
Copy link
Member
Having a consistent variable name helps simplify efforts to identify C globals that need to be moved. (A consistent name is easier to ignore.)
ericsnowcurrently
added
the
skip news
label
ericsnowcurrently
requested review from
berkerpeksag and
rhettinger
as code owners
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
Copy link
Member
vstinner
commented
May 24, 2019
vstinner commented
May 24, 2019I'm not super excited by PR only changing the coding style. Can't you use a tool which understand that the static is a constant and it's value is constant?
Copy link
Member Author
ericsnowcurrently
commented
May 29, 2019
ericsnowcurrently commented
May 29, 2019You're right. :)
ericsnowcurrently
closed this
Copy link
Member
vstinner
commented
May 29, 2019
vstinner commented
May 29, 2019Sorry :-(
ericsnowcurrently
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment