bpo-36991: Fix incorrect exception escaping ZipFile.extract() by berkerpeksag ยท Pull Request #13632 ยท python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

serhiy-storchaka

@serhiy-storchaka

@berkerpeksag

Thanks for the review, Serhiy! Yes, I'm going to add it before merging the PR.

@taleinat

Ping! This is ready to go except for a NEWS entry, so we should really just get it over with...

@gpshead gpshead changed the title bpo-36991: Fix TypeError in ZipFile.extract() bpo-36991: Fix incorrect exception escaping ZipFile.extract()

Sep 12, 2019

gpshead

@miss-islington

Thanks @berkerpeksag for the PR, and @gpshead for merging it ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 3.8.
๐Ÿ๐Ÿ’โ›๐Ÿค–

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 12, 2019
โ€ฆGH-13632)

(cherry picked from commit 2f1b857)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>

@bedevere-bot

@taleinat

@gpshead, should this not also be backported to 3.7?

@miss-islington

Thanks @berkerpeksag for the PR, and @gpshead for merging it ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 3.7.
๐Ÿ๐Ÿ’โ›๐Ÿค– I'm not a witch! I'm not a witch!

@miss-islington

Sorry, @berkerpeksag and @gpshead, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2f1b857562b0f1601c9019db74c29b7d7e21ac9f 3.7

miss-islington added a commit that referenced this pull request

Sep 12, 2019
(cherry picked from commit 2f1b857)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>

@berkerpeksag

@gpshead thank you for taking care of the PR!

Labels

type-bug

An unexpected behavior, bug, or error