Revert "bpo-34037, asyncio: add BaseEventLoop.wait_executor_on_close (GH-13786)" by ambv · Pull Request #13802 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ambv

Copy link Copy Markdown

Contributor

@ambv ambv commented

Jun 4, 2019

edited by bedevere-bot

Loading

This reverts commit 0f0a30f.

We need to revert this before b1 due to it being a new documented public API.

https://bugs.python.org/issue34037

@ambv

Copy link Copy Markdown

Contributor Author

ambv commented

Jun 4, 2019

Also, @1st1 requested this change not to be released as comment on the original PR.

@ambv ambv merged commit 7f9a2ae into python:master

Jun 4, 2019

@bedevere-bot

Copy link Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv

Copy link Copy Markdown

Contributor Author

ambv commented

Jun 4, 2019

There will come a day when I remember to replace # with GH-.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambv @bedevere-bot @1st1 @the-knights-who-say-ni