bpo-36918, test_urllib: Silence FakeHTTPConnection destructor errors by vstinner · Pull Request #13955 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
bpo-36918, test_urllib: Silence FakeHTTPConnection destructor errors#13955
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:test_urllib_del
bpo-36918, test_urllib: Silence FakeHTTPConnection destructor errors#13955
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:test_urllib_del
Conversation
Copy link Copy Markdown
Member
Implement FakeHTTPConnection.close() to silence destructor errors.
Co-Authored-By: Xtreak tir.karthi@gmail.com
Implement FakeHTTPConnection.close() to silence destructor errors. Co-Authored-By: Xtreak <tir.karthi@gmail.com>
vstinner
added
the
skip news
label
the-knights-who-say-ni
added
the
CLA signed
label
vstinner
mentioned this pull request
Copy link Copy Markdown
Member Author
vstinner
commented
Jun 11, 2019
vstinner commented
Jun 11, 2019Oh. It was too easy: test_urllib2 fails with my change :-(
Copy link Copy Markdown
Member
tirkarthi
commented
Jun 11, 2019
tirkarthi commented
Jun 11, 2019Yes, this was my first approach as well but test_urllib2 explicitly checks Fakesocket is closed.
Copy link Copy Markdown
Member Author
vstinner
commented
Jun 12, 2019
vstinner commented
Jun 12, 2019This PR is wrong. I wrote PR #13996 which is correct.
vstinner
closed this
vstinner
deleted the
test_urllib_del
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment