bpo-36511: clean up python process before deploy by paulmon · Pull Request #14431 · python/cpython
Conversation
If the previous buildbot test times out, there will be orphaned python processes that prevent deploy from working. Kill python.exe processes before trying to clean remote test directory
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, provided that the kill command exists :). I may be operating from out of date information, but I thought Windows only offered taskkill /IM python.exe?
Agreed with Zachary - "kill" isn't a Windows cmd.exe command (it is an alias in PowerShell), and I'm pretty sure you've only got cmd.exe commands at the other end of the SSH connection (since dir /b won't work in PowerShell).
Unless it's a new/extra addition on the buildbot?
kill.exe is a command on Windows IoT Core which is what the buildbot is running.
There is no taskkill.exe on Windows IoT Core.
I haven't seen this problem occur since I made this PR.
The last time the arm32 worker machine was producing bad results (stack overflow test kept failing)
because it was unhealthy a reboot was required to recover it.
Ok, we'll give this a try then.
paulmon
mannequin
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters