Home Original page

bpo-18374: fix wrong col_offset of some ast.BinOp instances by cfbolz · Pull Request #14607 · python/cpython

@cfbolz 

Nested BinOp instances (e.g. a+b+c) had a wrong col_offset for the
second BinOp (e.g. 2 instead of 0 in the example). Fix it by using the
correct st node to copy the line and col_offset from in ast.c.

asottile

ilevkivskyi

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 8, 2019 
…-14607)

Nested BinOp instances (e.g. a+b+c) had a wrong col_offset for the
second BinOp (e.g. 2 instead of 0 in the example). Fix it by using the
correct st node to copy the line and col_offset from in ast.c.
(cherry picked from commit 110a47c)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>

ilevkivskyi

ilevkivskyi

miss-islington added a commit that referenced this pull request

Jul 8, 2019 
Nested BinOp instances (e.g. a+b+c) had a wrong col_offset for the
second BinOp (e.g. 2 instead of 0 in the example). Fix it by using the
correct st node to copy the line and col_offset from in ast.c.
(cherry picked from commit 110a47c)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>

@cfbolz cfbolz deleted the bpo-18374-fix-col-offset-binop branch

July 9, 2019 15:25

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019 
…-14607)

Nested BinOp instances (e.g. a+b+c) had a wrong col_offset for the
second BinOp (e.g. 2 instead of 0 in the example). Fix it by using the
correct st node to copy the line and col_offset from in ast.c.

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020 
…-14607)

Nested BinOp instances (e.g. a+b+c) had a wrong col_offset for the
second BinOp (e.g. 2 instead of 0 in the example). Fix it by using the
correct st node to copy the line and col_offset from in ast.c.