[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) by vstinner · Pull Request #14772 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.5k
Merged
[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814)#14772
larryhastings merged 2 commits intopython:3.5from
vstinner:urlnorm35
[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814)#14772
larryhastings merged 2 commits intopython:3.5from
vstinner:urlnorm35
Conversation
Copy link Copy Markdown
Member
(cherry picked from commit 8d0ef0b)
Co-authored-by: Steve Dower steve.dower@python.org
(cherry picked from commit fd1771d)
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
vstinner
changed the title
bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814)
[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814)
Copy link Copy Markdown
Member Author
vstinner
commented
Jul 14, 2019
vstinner commented
Jul 14, 2019https://bugs.python.org/issue36742 is not fully fixed in the 3.5 branch: commit 4655d57 wasn't enough. We also need this second fix which is a backport from Python 3.6.
vstinner
requested a review
from zooba
Copy link Copy Markdown
Contributor
larryhastings
commented
Jul 14, 2019
larryhastings commented
Jul 14, 2019Just to confirm: this PR doesn't change any code in the standard library. It only changes tests. That's what you wanted?
Copy link Copy Markdown
Member Author
vstinner
commented
Jul 14, 2019
vstinner commented
Jul 14, 2019It changes the urllib module. I backported the change, I didn't make any change.
larryhastings
merged commit
095373c
into
python:3.5
Copy link Copy Markdown
bedevere-bot
commented
Sep 7, 2019
bedevere-bot commented
Sep 7, 2019@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
bedevere-bot
removed
the
awaiting core review
label
Copy link Copy Markdown
Contributor
larryhastings
commented
Sep 7, 2019
larryhastings commented
Sep 7, 2019Thanks for the 3.5 backport love!
vstinner
deleted the
urlnorm35
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment