gh-148474: Fix _Py_hexlify_simd compilation with older clang by jmroot · Pull Request #148475 · python/cpython
Conversation
Apple clang prior to around Xcode 9 does not automatically generate a vector from a scalar shift operator RHS in this case. Doing it explicitly works with all versions and arguably also makes it clearer what is actually happening.
Apple clang prior to around Xcode 9 does not automatically generate a vector from a scalar shift operator RHS in this case. Doing it explicitly works with all versions and arguably also makes it clearer what is actually happening.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I hope that my NEWS entry change is correct (I don't know if we had the c file directives correctly set up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Labels
2 participants