Home Original page

bpo-36044: Avoid warnings in Windows PGO build and add lzma, bz2 and sqlite coverage by zooba · Pull Request #14985 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@zooba

Copy link Copy Markdown

Member

@zooba zooba commented

Jul 28, 2019

•

edited by miss-islington

Loading

https://bugs.python.org/issue36044

Automerge-Triggered-By: @zooba

@gpshead

Copy link Copy Markdown

Member

gpshead commented

Jul 29, 2019

I doubt test_bz2 and test_lzma and test_sqlite add much given the important thing is compiling the bz2 and lzma and sqlite3 libraries themselves with PGO (which isn't part of our build). but these tests in total only take ~11 seconds so it doesn't hurt.

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 29, 2019 
…sqlite coverage (pythonGH-14985)

https://bugs.python.org/issue36044

Automerge-Triggered-By: @zooba
(cherry picked from commit e1b9002)

Co-authored-by: Steve Dower <steve.dower@python.org>

@bedevere-bot

Copy link Copy Markdown

GH-14997 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request

Jul 29, 2019 
…sqlite coverage (GH-14985)

https://bugs.python.org/issue36044

Automerge-Triggered-By: @zooba
(cherry picked from commit e1b9002)

Co-authored-by: Steve Dower <steve.dower@python.org>

@zooba zooba deleted the bpo-36044-win branch

July 30, 2019 01:01

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request

Jul 20, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @gpshead @miss-islington @bedevere-bot @the-knights-who-say-ni