bpo-36876: Fix the globals checker tool. by ericsnowcurrently · Pull Request #16058 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.2k
Merged
ericsnowcurrently merged 4 commits intopython:masterfrom
Sep 12, 2019Merged
bpo-36876: Fix the globals checker tool.#16058
ericsnowcurrently merged 4 commits intopython:masterfrom
bpo-36876: Fix the globals checker tool.#16058
ericsnowcurrently merged 4 commits intopython:masterfrom
Conversation
Copy link
Member
There are some missing variables and the definition of "object" isn't quite right. This PR fixes that. It also adds a TODO which captures all the globals that need to get fixed.
ericsnowcurrently added 4 commits
September 12, 2019 14:51
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
ericsnowcurrently
added
skip news
and removed
awaiting core review
labels
ericsnowcurrently
merged commit
088b63e
into
python:master
ericsnowcurrently
deleted the
globals-checker-update
branch
ericsnowcurrently
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment