Home Original page

[3.8] bpo-33418: Restore tp_clear for function object by nascheme · Pull Request #16502 · python/cpython

Conversation

This is a revert of the revert (pythonGH-15826).  Having a tp_clear for
functions should be safe (and helpful) now that bpo-38006 has been
fixed.

tim-one

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ambv ambv changed the title [3.8] Restore tp_clear for function object. [3.8] bpo-33418: Restore tp_clear for function object

Oct 1, 2019

@ambv

For reference:

  • this has never been reverted on master (3c45240 is still active there) so it doesn't need a "forward-port" there
  • this feature has been there for all published prereleases of 3.8 so it's pretty well covered with tests, it's safe to restore it now

@bedevere-bot

@ambv: Please replace # with GH- in the commit message next time. Thanks!

Labels